Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styling): ms-select filter should use same color as other filters #1396

Merged
merged 1 commit into from Feb 14, 2024

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Feb 14, 2024

  • this is a very small border color difference (#aaa instead of #ccc for all other filters, so ms-select were standing out because their border were slightly darker). The filled ms-select filter(s) also had a background gray color that was merging with the primary box shadow color (green below) which was not a pure color, now it's all good.

Before

image

After

image

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0a34691) 99.8% compared to head (e404229) 99.8%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1396   +/-   ##
======================================
  Coverage    99.8%   99.8%           
======================================
  Files         199     199           
  Lines       21559   21559           
  Branches     7204    7204           
======================================
  Hits        21495   21495           
  Misses         58      58           
  Partials        6       6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit a30d590 into master Feb 14, 2024
9 checks passed
@ghiscoding ghiscoding deleted the bugfix/ms-select-border branch February 14, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants