Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common): upgrade multiple-select-vanilla to v2 #1401

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Feb 22, 2024

  • see multiple-select-vanilla v2 release for more info.
  • the main difference is mostly a UX change that switches from tabIndex to arrow navigation highlight. Except the UX changes, the upgrade is mainly transparent for most users.

Copy link

stackblitz bot commented Feb 22, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fe2dbc3) 99.8% compared to head (61e99a4) 99.8%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #1401    +/-   ##
=======================================
  Coverage    99.8%   99.8%            
=======================================
  Files         199     199            
  Lines       21559   21559            
  Branches     6938    7204   +266     
=======================================
  Hits        21495   21495            
+ Misses         64      58     -6     
- Partials        0       6     +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit d6bb1d7 into master Feb 22, 2024
7 checks passed
@ghiscoding ghiscoding deleted the feat/ms-select-vanilla-v2 branch February 22, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant