Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): add Composite Editor onRendered lifecycle callback option #1410

Merged
merged 1 commit into from
Mar 2, 2024

Conversation

ghiscoding
Copy link
Owner

  • with the new Dark Mode, we needed a way to add attributes to the composite modal element when using Bootstrap, this new lifecycle is to help with that

- with the new Dark Mode, we needed a way to add attributes to the composite modal element when using Bootstrap, this new lifecycle is to help with that
Copy link

stackblitz bot commented Mar 2, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@ghiscoding ghiscoding changed the title feat(editor): add onRendered lifecycle callback option feat(editor): add onRendered lifecycle callback option to Composite Editor Mar 2, 2024
@ghiscoding ghiscoding changed the title feat(editor): add onRendered lifecycle callback option to Composite Editor feat(editor): add Composite Editor onRendered lifecycle callback option Mar 2, 2024
Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (4ef94fb) to head (e4c4c5a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1410     +/-   ##
========================================
+ Coverage    99.8%   99.8%   +0.1%     
========================================
  Files         199     199             
  Lines       21597   21599      +2     
  Branches     7085    7086      +1     
========================================
+ Hits        21533   21535      +2     
  Misses         58      58             
  Partials        6       6             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 9d348d6 into master Mar 2, 2024
8 checks passed
@ghiscoding ghiscoding deleted the feat/composite-rendered-lifecycle branch March 2, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant