Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revisit package exports to pass "are the types wrong" #1440

Merged
merged 1 commit into from Mar 25, 2024

Conversation

ghiscoding
Copy link
Owner

  • a recent commit made the exports a bit simpler but displays 1 unexpected syntax error on are the types wrong
  • use the same exports that we use in multiple-select-vanilla since that one doesn't display that error

- a recent commit made the `exports` a bit simpler but displays 1 unexpected syntax error on [are the types wrong](https://arethetypeswrong.github.io/?p=%40slickgrid-universal%2Fcommon%404.6.0)
- use the same `exports` that we use in `multiple-select-vanilla` since that one doesn't display that error
Copy link

stackblitz bot commented Mar 25, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (b4712e9) to head (9ca9bbc).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #1440    +/-   ##
=======================================
  Coverage    99.8%   99.8%            
=======================================
  Files         199     199            
  Lines       21617   21617            
  Branches     7098    7235   +137     
=======================================
  Hits        21553   21553            
  Misses         58      58            
  Partials        6       6            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 20229f7 into master Mar 25, 2024
8 checks passed
@ghiscoding ghiscoding deleted the bugfix/package-exports branch March 25, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant