Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add getFilterArgs() to SlickDataView #1457

Merged
merged 2 commits into from Apr 5, 2024

Conversation

ghiscoding
Copy link
Owner

as per original SlickGrid PR 1007

It would be very handy for developers to have ability to receive extra arguments of filter function. For example when filter is applyed we can:

  • write a custom date editor which can suggest a year for user, relying on the selected year filter;
  • fill cell values automatically when adding a new row, otherwise the row will not be displayed;
  • and much more.

Previously there was ability to receive extra arguments of filter function by using dataView.filters property and much featers have already been written by using it. Now we need a way to keep these features working.

Copy link

stackblitz bot commented Apr 5, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (5ab671b) to head (f31c3a0).

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1457     +/-   ##
========================================
+ Coverage    99.8%   99.8%   +0.1%     
========================================
  Files         199     199             
  Lines       21691   21693      +2     
  Branches     7124    7261    +137     
========================================
+ Hits        21627   21629      +2     
  Misses         58      58             
  Partials        6       6             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 7563126 into master Apr 5, 2024
6 checks passed
@ghiscoding ghiscoding deleted the feat/get-filter-args branch April 5, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants