fix(OData): sorting columns via id instead of field property name, fixes #1467
#1469
Conversation
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1469 +/- ##
========================================
- Coverage 99.8% 99.8% -0.0%
========================================
Files 199 199
Lines 21707 21706 -1
Branches 7262 7261 -1
========================================
- Hits 21643 21642 -1
Misses 58 58
Partials 6 6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
LGTM, will wait for @jr01 review if he has a chance. Thanks
Also just so you know, there's also an Example 15 with OData demo which is a little less busy in terms of demo functionalities, the only difference is that it uses RxJS so it was mainly added to test that part. So if we ever want to add more stuff in the demo, then the Example 15 might be ok too. Cheers
|
|
||
| cy.reload(); | ||
|
|
||
| cy.window().its('localStorage').invoke('getItem', STORAGE_KEY) |
There was a problem hiding this comment.
ah that's cool, I didn't know about this kind of usage 👍🏻
ghiscoding
changed the title
id instead of field property name, fixes #1467
|
Thanks for all contributions :) |
As mentioned in #1467 this fixes the OData Service to behave like the Graphql counterpart and store the columns id instead of field property, so that if the resulting gridState is persisted and re-applied, everything works as supposed
fixes #1467