Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styling): properly import Vanilla-Calendar CSS and only once #1492

Merged
merged 3 commits into from Apr 29, 2024

Conversation

ghiscoding
Copy link
Owner

  • we should have only 1 import and for it to be properly imported in SASS, we need to remove the file externsion when importing
  • fixes invalid import and missing CSS when tested in Salesforce

- we should have only 1 import and for it to be properly imported in SASS, we need to remove the file externsion when importing
- fixes invalid import and missing CSS when tested in Salesforce
Copy link

stackblitz bot commented Apr 29, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.7%. Comparing base (240cbd3) to head (4c99671).

Additional details and impacted files
@@          Coverage Diff          @@
##            next   #1492   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        197     197           
  Lines      21652   21652           
  Branches    6938    6938           
=====================================
  Hits       21586   21586           
  Misses        66      66           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 75dce74 into next Apr 29, 2024
6 checks passed
@ghiscoding ghiscoding deleted the bugfix/vanilla-calendar-css branch April 29, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants