Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common)!: make DOMPurify as optional sanitizer grid option #1503

Merged
merged 4 commits into from
May 3, 2024

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented May 3, 2024

  • some user might want to use dompurify, while some other users might want to use isomorphic-dompurity for SSR support, while some users might not want any sanitizer at all.
  • to satisfy all these use cases, we'll remove DOMPurify from the core and make it optional via the sanitizer grid option
  • also provide the function as grid.sanitizeHtmlString() for users who want to call the function without referencing the grid options

- some user might want to use `dompurify`, while some other users might want to use `isomorphic-dompurity` for SSR support, while some users might not want any sanitizer at all.
- to satisfy all these use cases, we'll remove DOMPurify from the core and make it optional via the `sanitizer` grid option
Copy link

stackblitz bot commented May 3, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (e82d092) to head (6ed32c6).

Additional details and impacted files
@@           Coverage Diff           @@
##            next   #1503     +/-   ##
=======================================
+ Coverage   99.7%   99.8%   +0.1%     
=======================================
  Files        197     197             
  Lines      21606   21584     -22     
  Branches    7190    7180     -10     
=======================================
- Hits       21540   21520     -20     
+ Misses        60      58      -2     
  Partials       6       6             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 0aa0859 into next May 3, 2024
6 checks passed
@ghiscoding ghiscoding deleted the feat/sanitizer-grid-option branch May 3, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants