Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): only show tooltip that has value #1511

Merged
merged 1 commit into from May 7, 2024

Conversation

ghiscoding
Copy link
Owner

  • the previous code was having a simple check of the final output text, however when using DOMPurify it returns a TrustedHTML object which is considered defined even though it could be empty.
  • we can fix the issue via 2 changes (1. sanitize only string value, 2. check tooltip value against toString()

- the previous code was having a simple check of the final output text, however when using DOMPurify it returns a TrustedHTML object which is considered defined even though it could be empty.
- we can fix the issue via 2 changes (1. sanitize only string value, 2. check tooltip value against `toString()`
Copy link

stackblitz bot commented May 7, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (94b836a) to head (519022f).
Report is 1 commits behind head on next.

Additional details and impacted files
@@          Coverage Diff           @@
##            next   #1511    +/-   ##
======================================
  Coverage   99.8%   99.8%            
======================================
  Files        198     198            
  Lines      21616   21616            
  Branches    6946    7217   +271     
======================================
  Hits       21552   21552            
+ Misses        64      58     -6     
- Partials       0       6     +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 2ff15da into next May 7, 2024
6 checks passed
@ghiscoding ghiscoding deleted the bugfix/tooltip-filled-only branch May 7, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants