feat(filters): add OperatorType.custom for custom backend service
#1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adding a `OperatorType.custom` so that the users can use BUT the developers will have to implement their own code to go with it. This operator does nothing by itself unless the developers implement some code to go with it. It was only added to provide an easy way for the users to choose a valid operator. - typically the developers will have to provide his own code implementation, typically a backend service (it could be by extending and overriding the OData/GraphQL service with their own usage). - it was added because of this Satck Overflow [question](https://stackoverflow.com/questions/78471412/angular-slickgrid-filter)
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1526 +/- ##
========================================
+ Coverage 99.8% 99.8% +0.1%
========================================
Files 198 198
Lines 21616 21617 +1
Branches 7219 6949 -270
========================================
+ Hits 21555 21556 +1
- Misses 55 61 +6
+ Partials 6 0 -6 ☔ View full report in Codecov by Sentry. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OperatorType.customso that the users can use BUT the developers will have to implement their own code to go with it. This operator does nothing by itself unless the developers implement some code to go with it. It was only added to provide an easy way for the users to choose a valid operator.