-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(GraphQL): add filterQueryOverride
to GraphQL Service
#1549
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1549 +/- ##
========================================
+ Coverage 99.8% 99.8% +0.1%
========================================
Files 198 198
Lines 21685 21691 +6
Branches 7112 7253 +141
========================================
+ Hits 21624 21630 +6
Misses 55 55
Partials 6 6 ☔ View full report in Codecov by Sentry. |
@zewa666 so I think I got a similar approach to your OData PR #1536, however 1 major thing that makes it apart is that instead of returning a string, I'm actually asking the user to return an object of the shape However, while doing this PR, I noticed that my I know you're using OData and not GraphQL, but it would still be nice if you could take a look at my PR and tell me if it makes any sense (I don't even have a GraphQL server to test with) but I followed this SO answer that inspired my approach which I think is correct: https://stackoverflow.com/a/37981802/1212166 |
sure I'll take a look tonight. btw can you target my branch as destination for the merge? I'm genuinly interested if thats possible, but no probs I can move the files around as you mentioned anyways. with regards to testing perhaps a quick way to ramp up a server with auto graphql features would be to look into Hasura. or if you just want to spin up a demo on top of json files perhaps https://github.com/marmelab/json-graphql-server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aside from the small comment above LGTM
filterQueryOverride
to OData Service #1536 but for GraphQL ServicefilterQueryOverride
which provides a way for the user to override default filter operator and GraphQL query