Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styling): Grid Menu, Col Picker labels should take full width #1564

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Jun 9, 2024

  • the Column Picker & Grid Menu, cols picker list labels were not center aligned and were also not taking full width
  • all the commands above already take full width, so it makes sense to also make picker list behave the same

before fix

brave_r90Vs3eE8q

after fix

brave_ixEKYrhZBZ

- the Column Picker & Grid Menu, cols picker list labels were not center aligned and were also not taking full width
Copy link

stackblitz bot commented Jun 9, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Jun 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (bfdec1e) to head (4c50060).

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1564   +/-   ##
======================================
  Coverage    99.8%   99.8%           
======================================
  Files         198     198           
  Lines       21727   21727           
  Branches     6999    6999           
======================================
  Hits        21666   21666           
  Misses         61      61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit e942539 into master Jun 10, 2024
7 checks passed
@ghiscoding ghiscoding deleted the bugfix/col-picker-align-full-width branch June 10, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant