Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filters): skipCompoundOperatorFilterWithNullInput skip empty string #1566

Merged
merged 4 commits into from
Jun 10, 2024

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Jun 10, 2024

  • when enabling skipCompoundOperatorFilterWithNullInput it was only working the first time and if the user clicked on the input (or type something and then erases it), it no longer undefined and was no longer skipping null input like it should. So we simply need to compare against not just undefined but also against empty string '' and if so then skip it filtering
  • note however that we should only skip null value when previous value was not null so that we get full list back

below is a demo of the small bug

msedge_3Bv1hGTjPP

after fix

msedge_DBCAquYb3y

Copy link

stackblitz bot commented Jun 10, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (e942539) to head (84fbd1b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1566     +/-   ##
========================================
+ Coverage    99.8%   99.8%   +0.1%     
========================================
  Files         198     198             
  Lines       21727   21729      +2     
  Branches     7273    7274      +1     
========================================
+ Hits        21666   21668      +2     
  Misses         55      55             
  Partials        6       6             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 4d69bc0 into master Jun 10, 2024
6 checks passed
@ghiscoding ghiscoding deleted the bugfix/skip-null-input-value-with-compound branch June 10, 2024 15:41
ghiscoding pushed a commit that referenced this pull request Jun 11, 2024
- review Compound Date & Compound Slider Filters to be more aligned with Compound Input Text Filter after PR #1566
ghiscoding added a commit that referenced this pull request Jun 11, 2024
…1568)

- review Compound Date & Compound Slider Filters to be more aligned with Compound Input Text Filter after PR #1566
@ghiscoding ghiscoding mentioned this pull request Jun 11, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants