Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GraphQL): filter <> is Not_Contains instead of Not_Equal #1571

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Jun 13, 2024

  • while investigating for issue Filter for blanks / non blanks #1569, I found out that the GraphQL <> was set to be the equivalent of != but this is in fact false, since the <> is meant to represent Not_Contains while != is meant to represent Not_Equals and they both work differently since <> is for a substring but the != is for the entire string
  • it is also related to the PR fix(filters): filters with != (not equal empty) should return non-blanks #1570
  • Note that OData doesn't have a "Not Contains" query filter and so I only made the modification for GraphQL (OData has its own switch case for each operator)

- while investigating for issue #1569, I found that the GraphQL `<>` was set to be the equivalent of `!=` but this is in fact false, the `<>` is meant to represent `Not_Contains` while `!=` is meant to represent `Not_Equals` and they both work differently since `<>` is for a substring but the `!=` is for the entire string
Copy link

stackblitz bot commented Jun 13, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (9837ef1) to head (3be073c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #1571    +/-   ##
=======================================
  Coverage    99.8%   99.8%            
=======================================
  Files         198     198            
  Lines       21731   21731            
  Branches     7278    7005   -273     
=======================================
  Hits        21670   21670            
  Misses         61      61            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit c6f1cf3 into master Jun 13, 2024
7 checks passed
@ghiscoding ghiscoding deleted the bugfix/search-graphql-non-blanks branch June 13, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant