Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): rename i18n to translater & fix few other issues #174

Merged
merged 3 commits into from Nov 30, 2020

Conversation

ghiscoding
Copy link
Owner

  • fix couple of issues found for the lib to work with Aurelia-Slickgrid

ghiscoding and others added 2 commits November 29, 2020 23:38
- fix couple of issues found for the lib to work with Aurelia-Slickgrid
@codecov
Copy link

codecov bot commented Nov 30, 2020

Codecov Report

Merging #174 (500a61d) into master (38414a1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #174   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          200       200           
  Lines        11684     11687    +3     
  Branches      3980      3981    +1     
=========================================
+ Hits         11684     11687    +3     
Impacted Files Coverage Δ
packages/common/src/formatters/formatters.index.ts 100.00% <ø> (ø)
packages/common/src/editors/dateEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/longTextEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/selectEditor.ts 100.00% <100.00%> (ø)
packages/common/src/enums/index.ts 100.00% <100.00%> (ø)
...common/src/formatters/translateBooleanFormatter.ts 100.00% <100.00%> (ø)
...ckages/common/src/formatters/translateFormatter.ts 100.00% <100.00%> (ø)
packages/common/src/services/grid.service.ts 100.00% <100.00%> (ø)
packages/excel-export/src/excelExport.service.ts 100.00% <100.00%> (ø)
packages/file-export/src/fileExport.service.ts 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38414a1...500a61d. Read the comment docs.

@ghiscoding ghiscoding merged commit 34c963a into master Nov 30, 2020
@ghiscoding ghiscoding deleted the bugfix/grid-options-translater-override branch November 30, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant