Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sorting): add cellValueCouldBeUndefined in grid option for sorting #202

Merged
merged 1 commit into from Dec 17, 2020

Conversation

ghiscoding
Copy link
Owner

  • Salesforce very often removes property of an object if it's detected as null and this becomes undefined in slickgrid, add a salesforce global grid options to deal with these undefined property

- Salesforce very often removes property of an object if it's detected as null and this becomes undefined in slickgrid, add a salesforce global grid options to deal with these undefined property
@codecov
Copy link

codecov bot commented Dec 17, 2020

Codecov Report

Merging #202 (89ab85a) into master (1b1cea2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #202    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          206       206            
  Lines        11853     11854     +1     
  Branches      4054      3905   -149     
==========================================
+ Hits         11853     11854     +1     
Impacted Files Coverage Δ
packages/common/src/services/collection.service.ts 100.00% <100.00%> (ø)
packages/common/src/services/sort.service.ts 100.00% <100.00%> (ø)
packages/common/src/sortComparers/dateUtilities.ts 100.00% <100.00%> (ø)
...es/common/src/sortComparers/numericSortComparer.ts 100.00% <100.00%> (ø)
...mmon/src/sortComparers/objectStringSortComparer.ts 100.00% <100.00%> (ø)
packages/common/src/sortComparers/sortUtilities.ts 100.00% <100.00%> (ø)
...ges/common/src/sortComparers/stringSortComparer.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b1cea2...89ab85a. Read the comment docs.

@ghiscoding ghiscoding merged commit 865256e into master Dec 17, 2020
@ghiscoding ghiscoding deleted the bugfix/sort-with-undefined-values branch December 17, 2020 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant