Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): change moment/lodash imports so it works with ES6 module #210

Merged
merged 1 commit into from Dec 22, 2020

Conversation

ghiscoding
Copy link
Owner

  • ES6 wants us to use import moment but in TypeScript it asks for import * as moment, if we do const moment = moment_['default'] || moment_; we will get either/or, whichever works first and that works on both side of the fence

- ES6 wants us to use `import moment` but in TypeScript it asks for `import * as moment`, if we do `const moment = moment_['default'] || moment_;` we will get either/or, whichever works first and that works on both side of the fence
@codecov
Copy link

codecov bot commented Dec 22, 2020

Codecov Report

Merging #210 (7a82cea) into master (3b3b463) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #210   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          207       207           
  Lines        11904     11904           
  Branches      3916      3927   +11     
=========================================
  Hits         11904     11904           
Impacted Files Coverage Δ
packages/common/src/editors/dateEditor.ts 100.00% <100.00%> (ø)
...on/src/filter-conditions/executeMappedCondition.ts 100.00% <100.00%> (ø)
packages/common/src/filters/dateRangeFilter.ts 100.00% <100.00%> (ø)
...ckages/common/src/formatters/formatterUtilities.ts 100.00% <100.00%> (ø)
packages/common/src/services/filter.service.ts 100.00% <100.00%> (ø)
packages/common/src/services/gridState.service.ts 100.00% <100.00%> (ø)
packages/common/src/services/pagination.service.ts 100.00% <100.00%> (ø)
packages/common/src/services/utilities.ts 100.00% <100.00%> (ø)
packages/common/src/sortComparers/dateUtilities.ts 100.00% <100.00%> (ø)
packages/excel-export/src/excelExport.service.ts 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b3b463...7a82cea. Read the comment docs.

@ghiscoding ghiscoding merged commit 2d25d3b into master Dec 22, 2020
@ghiscoding ghiscoding deleted the bugfix/moment-lodash-imports branch December 22, 2020 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant