Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugins): add missing Row Detail filtering code #239

Merged
merged 2 commits into from Jan 20, 2021

Conversation

ghiscoding
Copy link
Owner

  • get the item data context from its parrent object when using row detail

- get the item data context from its parrent object when using row detail
@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #239 (3173f8b) into master (563c0fa) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##            master      #239      +/-   ##
============================================
+ Coverage   100.00%   100.00%   +0.01%     
============================================
  Files          207       207              
  Lines        11930     11935       +5     
  Branches      3943      3948       +5     
============================================
+ Hits         11929     11935       +6     
+ Misses           1         0       -1     
Impacted Files Coverage Δ
packages/common/src/services/filter.service.ts 100.00% <100.00%> (ø)
...ges/vanilla-bundle/src/services/resizer.service.ts 100.00% <0.00%> (+1.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 563c0fa...3173f8b. Read the comment docs.

@ghiscoding ghiscoding merged commit d9cad63 into master Jan 20, 2021
@ghiscoding ghiscoding deleted the bugfix/filter-service-row-detail branch January 20, 2021 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant