Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(component): Composite Editor sometime shows empty mass update form #244

Merged
merged 2 commits into from Jan 27, 2021

Conversation

ghiscoding
Copy link
Owner

  • when using Mass Update without the flag enableAddRow grid option, it could sometime show an empty form, this PR fixes that

- when using Mass Update without the flag `enableAddRow` grid option, it could sometime show an empty form, this PR fixes that
@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #244 (44c463b) into master (b255220) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #244   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          207       207           
  Lines        11976     11979    +3     
  Branches      4114      4115    +1     
=========================================
+ Hits         11976     11979    +3     
Impacted Files Coverage Δ
...-component/src/slick-composite-editor.component.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b255220...44c463b. Read the comment docs.

@ghiscoding ghiscoding merged commit d3ad4db into master Jan 27, 2021
@ghiscoding ghiscoding deleted the bugfix/composite-editor-mass-update branch January 27, 2021 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant