Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pinning): reordering cols position freezing cols shouldn't affect #275

Merged
merged 3 commits into from Mar 2, 2021

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Mar 2, 2021

  • the steps to reproduce the issue was to create a grid with frozenColumn in the grid options, then change column position (cols reordering) and finally open header menu and freeze any of the column and the bug was that it was going back to original positions while it should keep new positions and just add new freeze column

XMqeZnN

- the steps to reproduce the issue was to create a grid with `frozenColumn` in the grid options, then change column position (cols reordering) and finally open header menu and freeze any of the column and the bug was that it was going back to original positions while it should keep new positions and just add new freeze column
@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #275 (a64f3c9) into master (3b170f2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #275   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          209       209           
  Lines        12396     12406   +10     
  Branches      4236      4236           
=========================================
+ Hits         12396     12406   +10     
Impacted Files Coverage Δ
...kages/common/src/extensions/headerMenuExtension.ts 100.00% <100.00%> (ø)
.../common/src/services/groupingAndColspan.service.ts 100.00% <100.00%> (ø)
packages/common/src/services/shared.service.ts 100.00% <100.00%> (ø)
...bundle/src/components/slick-vanilla-grid-bundle.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b170f2...a64f3c9. Read the comment docs.

@ghiscoding ghiscoding merged commit a30665d into master Mar 2, 2021
@ghiscoding ghiscoding deleted the bugfix/frozen-column-reorder branch March 2, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant