Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(resources): add RxJS support into Slickgrid-Universal via external package #280

Merged
merged 30 commits into from Mar 24, 2021

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Mar 6, 2021

This will add support of RxJS Observables with any Backend Services (like OData/GraphQL) which is the last missing piece for Angular-Slickgrid to finally use Slickgrid-Universal.

TODOs

  • working POC of RxJS 6 support with Slickgrid-Universal
    • create new Example15 to demo RxJS
    • create new Example in Aurelia-Slickgrid to demo RxJS as well
  • create an RxJS Facade (plain interface) to use within @slickgrid-universal/common package
  • add RxJS code in all Services/Backend code
  • add RxJS code in all Filters/Editors using collectionAsync
    • add collectionAsync with Observable into the demo to test Filter/Editor
  • add unit tests
  • add Cypress E2E tests (we can simply reuse Example 9 test suite)
  • upgrade from RxJS 6 to 7
  • rename/remove the Facade suffix from abstract class naming to avoid confusing for user of the lib (e.g. Angular-Slickgrid)
  • final test in SF make sure is still working as expected

@ghiscoding ghiscoding changed the title feat(resources): add RxJS support into Slickgrid-Universal via external package WIP - feat(resources): add RxJS support into Slickgrid-Universal via external package Mar 6, 2021
@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #280 (20d4f85) into master (ba703d8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #280    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          209       212     +3     
  Lines        12523     12659   +136     
  Branches      4112      4146    +34     
==========================================
+ Hits         12523     12659   +136     
Impacted Files Coverage Δ
packages/common/src/services/shared.service.ts 100.00% <ø> (ø)
...ackages/common/src/extensions/gridMenuExtension.ts 100.00% <100.00%> (ø)
packages/common/src/filters/autoCompleteFilter.ts 100.00% <100.00%> (ø)
packages/common/src/filters/filterFactory.ts 100.00% <100.00%> (ø)
packages/common/src/filters/filterUtilities.ts 100.00% <100.00%> (ø)
...ackages/common/src/filters/multipleSelectFilter.ts 100.00% <100.00%> (ø)
packages/common/src/filters/selectFilter.ts 100.00% <100.00%> (ø)
packages/common/src/filters/singleSelectFilter.ts 100.00% <100.00%> (ø)
packages/common/src/index.ts 100.00% <100.00%> (ø)
...ages/common/src/services/backendUtility.service.ts 100.00% <100.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba703d8...20d4f85. Read the comment docs.

@ghiscoding ghiscoding changed the title WIP - feat(resources): add RxJS support into Slickgrid-Universal via external package feat(resources): add RxJS support into Slickgrid-Universal via external package Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant