Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editors): add onSelect callback to Autocomplete Editor #286

Merged
merged 1 commit into from Mar 17, 2021

Conversation

ghiscoding
Copy link
Owner

  • since user cannot override the jQueryUI select callback (because that would break Slickgrid-Universal code), we can instead provide an extra callback, onSelect, to do the same with even more arguments

- since user cannot override the jQueryUI `select` callback (because that would break Slickgrid-Universal code), we can instead provide an extra callback, `onSelect`, to do the same with even more arguments
@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #286 (bad051f) into master (3174c86) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #286   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          209       209           
  Lines        12433     12436    +3     
  Branches      4253      4254    +1     
=========================================
+ Hits         12433     12436    +3     
Impacted Files Coverage Δ
packages/common/src/editors/autoCompleteEditor.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3174c86...bad051f. Read the comment docs.

@ghiscoding ghiscoding merged commit 2d106d4 into master Mar 17, 2021
@ghiscoding ghiscoding deleted the feat/autocomplete-onselect branch March 17, 2021 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant