Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(filters): add option to filter empty values for select filter #310

Merged
merged 4 commits into from Apr 14, 2021

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Apr 14, 2021

see new Wiki

@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #310 (1a1eb1c) into master (0e89f5e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #310   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          212       212           
  Lines        12716     12724    +8     
  Branches      4344      4350    +6     
=========================================
+ Hits         12716     12724    +8     
Impacted Files Coverage Δ
...ackages/common/src/filters/multipleSelectFilter.ts 100.00% <100.00%> (ø)
packages/common/src/filters/selectFilter.ts 100.00% <100.00%> (ø)
packages/common/src/filters/singleSelectFilter.ts 100.00% <100.00%> (ø)
packages/common/src/services/filter.service.ts 100.00% <100.00%> (ø)
...-component/src/slick-composite-editor.component.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e89f5e...1a1eb1c. Read the comment docs.

@ghiscoding ghiscoding merged commit c58a92a into master Apr 14, 2021
@ghiscoding ghiscoding deleted the feat/select-filter-empty-value branch April 14, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant