Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(service): should be able to update dataview item not shown in grid #730

Merged
merged 2 commits into from Aug 2, 2022

Conversation

ghiscoding
Copy link
Owner

  • even if an item is not showing in the grid, we should still be able to update it as long as it exists and is found in the DataView

- even if an item is not showing in the grid, we should still be able to update it as long as it exists and is found in the DataView
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #730 (d314778) into master (053806e) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #730   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          233       233           
  Lines        16438     16439    +1     
  Branches      5489      5490    +1     
=========================================
+ Hits         16437     16438    +1     
  Misses           1         1           
Impacted Files Coverage Δ
packages/common/src/services/grid.service.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@ghiscoding ghiscoding merged commit dc88c87 into master Aug 2, 2022
@ghiscoding ghiscoding deleted the chore/update-tree-data-item branch August 2, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant