Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tooltip): add a new "center" position option to SlickCustomTooltip #787

Merged
merged 1 commit into from Nov 1, 2022

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Nov 1, 2022

  • a centered tooltip is sometime useful and wasn't available prior to this PR, this will be especially useful with a Slider Range Filter

image

@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #787 (1fe83b2) into master (8ad54b5) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            master      #787    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          234       235     +1     
  Lines        16378     16578   +200     
  Branches      5498      5557    +59     
==========================================
+ Hits         16378     16578   +200     
Impacted Files Coverage Δ
...es/custom-tooltip-plugin/src/slickCustomTooltip.ts 100.00% <100.00%> (ø)
packages/common/src/constants.ts 100.00% <0.00%> (ø)
packages/common/src/interfaces/index.ts 100.00% <0.00%> (ø)
packages/common/src/editors/sliderEditor.ts 100.00% <0.00%> (ø)
packages/common/src/filters/sliderFilter.ts 100.00% <0.00%> (ø)
packages/common/src/filters/filters.index.ts 100.00% <0.00%> (ø)
packages/common/src/filters/filterUtilities.ts 100.00% <0.00%> (ø)
packages/common/src/filters/compoundDateFilter.ts 100.00% <0.00%> (ø)
packages/common/src/filters/compoundInputFilter.ts 100.00% <0.00%> (ø)
...ackages/common/src/filters/compoundSliderFilter.ts 100.00% <0.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding merged commit b019de5 into master Nov 1, 2022
@ghiscoding ghiscoding deleted the feat/centered-tooltip branch November 1, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant