Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filters): changing Slider value should update tooltip value #788

Merged
merged 2 commits into from Nov 3, 2022

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Nov 2, 2022

  • when using SlickCustomTooltip addon and changing slider value, it should update the tooltip value without having to leave the cell and rehovering to see the updated value, it turns out that calling onHeaderRowMouseEnter will have that effect as long as we add a small setTimeout delay

brave_uxWANvpJSe

- when using SlickCustomTooltip addon and changing slider value, it should update the tooltip value without having to leave the cell and rehovering to see the updated value, it turns out that calling `onHeaderRowMouseEnter` will have that effect as long as we add a small `setTimeout` delay
@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #788 (f96e7e0) into master (b085e07) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #788   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          235       235           
  Lines        16578     16578           
  Branches      5557      5554    -3     
=========================================
  Hits         16578     16578           
Impacted Files Coverage Δ
...ackages/common/src/filters/compoundSliderFilter.ts 100.00% <100.00%> (ø)
packages/common/src/filters/sliderFilter.ts 100.00% <100.00%> (ø)
packages/common/src/filters/sliderRangeFilter.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding merged commit 509a31d into master Nov 3, 2022
@ghiscoding ghiscoding deleted the chore/slider-tooltip-refresh branch November 3, 2022 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant