Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(addon): add group by sorting to SlickDraggableGrouping #814

Merged
merged 2 commits into from Nov 16, 2022

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Nov 16, 2022

  • provide an extra sort icon beside each group which allow us to sort each group independently
  • user can also chose to disable this new feature by using the hideGroupSortIcons option

brave_XRgHT6Efff

- provide an extra sort icon beside each group which allow us to sort each group independently
@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Merging #814 (eab7e98) into master (a25791a) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #814   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          238       239    +1     
  Lines        16308     16365   +57     
  Branches      5524      5547   +23     
=========================================
+ Hits         16308     16365   +57     
Impacted Files Coverage Δ
...es/common/src/extensions/slickDraggableGrouping.ts 100.00% <100.00%> (ø)
...es/common/src/sortComparers/booleanSortComparer.ts 100.00% <100.00%> (ø)
packages/common/src/sortComparers/index.ts 100.00% <100.00%> (ø)
...es/common/src/sortComparers/sortComparers.index.ts 100.00% <100.00%> (ø)
packages/common/src/sortComparers/sortUtilities.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding merged commit 962a756 into master Nov 16, 2022
@ghiscoding ghiscoding deleted the feat/slick-draggable-groupby-sorting branch November 16, 2022 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant