Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(formatters): add Currency Formatter and GroupTotalFormatter #850

Merged
merged 1 commit into from Dec 19, 2022

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Dec 19, 2022

add the following Formatter and GroupTotal Formatters (these new formatters will work nicely with Excel auto-detect custom format)

  • Formatters.currency
  • GroupTotalsFormatter.avgCurrency
  • GroupTotalsFormatter.sumTotalCurrency
  • GroupTotalsFormatter.sumTotalCurrencyColored

@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Merging #850 (3170f25) into master (05402e5) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #850   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          240       244    +4     
  Lines        16496     16565   +69     
  Branches      5872      5906   +34     
=========================================
+ Hits         16496     16565   +69     
Impacted Files Coverage Δ
packages/common/src/constants.ts 100.00% <100.00%> (ø)
...ackages/common/src/formatters/currencyFormatter.ts 100.00% <100.00%> (ø)
...ommon/src/formatters/dollarColoredBoldFormatter.ts 100.00% <100.00%> (ø)
...es/common/src/formatters/dollarColoredFormatter.ts 100.00% <100.00%> (ø)
packages/common/src/formatters/dollarFormatter.ts 100.00% <100.00%> (ø)
...ckages/common/src/formatters/formatterUtilities.ts 100.00% <100.00%> (ø)
packages/common/src/formatters/formatters.index.ts 100.00% <100.00%> (ø)
.../grouping-formatters/avgTotalsCurrencyFormatter.ts 100.00% <100.00%> (ø)
...rc/grouping-formatters/avgTotalsDollarFormatter.ts 100.00% <100.00%> (ø)
...rc/grouping-formatters/groupingFormatters.index.ts 100.00% <100.00%> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding merged commit ad373ab into master Dec 19, 2022
@ghiscoding ghiscoding deleted the feat/currency-formatters branch December 19, 2022 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant