Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formatters): Date Formatter should work with Date object #854

Merged
merged 4 commits into from Dec 21, 2022

Conversation

ghiscoding
Copy link
Owner

  • prior to this PR, a Date Formatter was returning an empty string when input was a Date object
  • also another problem was the sanitize of html tag, the function should really only be executed when input is a string type

- prior to this PR, a Date Formatter was returning an empty string when input was a Date object
- also another problem was the sanitize of html tag, the function should really only be executed when input is a string type
@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Merging #854 (b80e6f3) into master (31726ca) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #854   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          244       244           
  Lines        16565     16565           
  Branches      5904      5904           
=========================================
  Hits         16565     16565           
Impacted Files Coverage Δ
...ckages/common/src/formatters/formatterUtilities.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding merged commit 30b80e2 into master Dec 21, 2022
@ghiscoding ghiscoding deleted the bugfix/formatter-return-date-object branch December 21, 2022 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant