Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(exports): Date should always export w/Formatter unless false #856

Merged
merged 3 commits into from Dec 21, 2022

Conversation

ghiscoding
Copy link
Owner

  • it should always execute Date formatter even when undefined, unless exportWithFormatter is specifically set to False in that case it will return original Date input

- it should always execute Date formatter even when undefined, unless `exportWithFormatter` is specifically set to False in that case it will return original Date input
@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Merging #856 (2d9fa9f) into master (9d29e59) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #856   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          244       244           
  Lines        16571     16551   -20     
  Branches      5906      5881   -25     
=========================================
- Hits         16571     16551   -20     
Impacted Files Coverage Δ
packages/common/src/services/utilities.ts 100.00% <100.00%> (ø)
packages/excel-export/src/excelExport.service.ts 100.00% <100.00%> (ø)
packages/excel-export/src/excelUtils.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding merged commit 1b249e8 into master Dec 21, 2022
@ghiscoding ghiscoding deleted the bugfix/date-always-formatted branch December 21, 2022 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant