Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filters): provide flag to disable special chars input filter parsing #873

Merged
merged 1 commit into from Jan 20, 2023

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Jan 20, 2023

  • Slickgrid-Universal is by default parsing some special characters (<, >, =, *) when found in filter input value but in some rare occasion the user might have data that includes these special chars and might want to disable the parsing, this PR provide a new flag autoParseInputFilterOperator that will disable parsing when set to false and search the value as it is
  • this option is available from both the GridOption and the Column, the latter will always have precedence
  • ref Stack Overflow In angular slickgrid, the records with special characters "<" , "=" are not getting filtered

- Slickgrid-Universal is by default parsing some special characters (<, >, =, *) when found in filter input value but in some rare occasion the user might have data that includes these special chars and might want to disable the parsing, this PR provide a new flag to do that
- ref Stack Overflow [question](https://stackoverflow.com/questions/75155658/in-angular-slickgrid-the-records-with-special-characters-are-not-gett/75160978#75160978)
@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Merging #873 (9442802) into master (747c690) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #873   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          244       244           
  Lines        16556     16565    +9     
  Branches      5883      5895   +12     
=========================================
+ Hits         16556     16565    +9     
Impacted Files Coverage Δ
packages/common/src/services/filter.service.ts 100.00% <100.00%> (ø)
packages/graphql/src/services/graphql.service.ts 100.00% <100.00%> (ø)
packages/odata/src/services/grid-odata.service.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding merged commit 7e35dae into master Jan 20, 2023
@ghiscoding ghiscoding deleted the feat/column-filter-auto-parse-operator branch January 20, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant