chore(build): use ESBuild as alternative build for Salesforce #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
ghiscoding
commented
Feb 21, 2023
ghiscoding
commented
- assign jQuery to the window object so that we can bundle jQuery in the same slickgrid bundle, in other words we would only have 1 single static resource (zip) for the entire slickgrid-universal and that's it (since everything is bundled, jQuery and even SortableJS also become part of the bundle and aren't needed as extra resources)
- assign jQuery to the window object so that we can bundle jQuery in the same slickgrid bundle, in other words we would only have 1 single static resource (zip) for the entire slickgrid-universal and that's it (since everything is bundled, jQuery and even SortableJS also become part of the bundle and aren't needed as extra resources)
Codecov Report
@@ Coverage Diff @@
## master #911 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 244 245 +1
Lines 16595 16598 +3
Branches 5907 5907
=========================================
+ Hits 16595 16598 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ghiscoding
added a commit
that referenced
this pull request
Feb 24, 2023
- in a previous PR #911 to help with ESBuild bundle, we assigned jQuery to the global window object but that can cause duplicate jQuery version loaded and made Angular-Slickgrid Jest unit tests to fail with that problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.