Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): only create tooltip on header row/column from title attr #915

Merged
merged 1 commit into from Feb 23, 2023

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Feb 23, 2023

  • the feature of that takes the cell content and displays a tooltip when the cell isn't showing the entire text should only be displayed on a slick-cell type, it shouldn't do this action when hovering on a slick header. This was an issue that was found when hovering a select dropdown that ended up showing up the entire list of select options values instead of the selected values

- the feature of that takes the cell content and displays a tooltip when the cell isn't showing the entire text should only be displayed on a slick-cell type, it shouldn't do this action when hovering on a slick header
@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #915 (9d66b72) into master (609f6c5) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #915   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          245       245           
  Lines        16598     16601    +3     
  Branches      5907      5907           
=========================================
+ Hits         16598     16601    +3     
Impacted Files Coverage Δ
...es/custom-tooltip-plugin/src/slickCustomTooltip.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding merged commit 1d9c185 into master Feb 23, 2023
@ghiscoding ghiscoding deleted the bugfix/custom-tooltip-header-long-text branch February 23, 2023 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant