Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SlickDraggableGrouping should hide group elms when dragging #965

Merged
merged 4 commits into from Apr 30, 2023

Conversation

ghiscoding
Copy link
Owner

  • when dragging a column to a new group, it should hide all existing grouped elements
  • also fixes an issue were the dropzone hovering wasn't working as it should

- when dragging a column to a new group, it should hide all existing grouped elements
- also fixes an issue were the dropzone hovering wasn't working as it should
@codecov
Copy link

codecov bot commented Apr 30, 2023

Codecov Report

Merging #965 (d5b69fe) into master (fe9cf80) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #965   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          244       244           
  Lines        16613     16610    -3     
  Branches      5908      5905    -3     
=========================================
- Hits         16613     16610    -3     
Impacted Files Coverage Δ
...es/common/src/extensions/slickDraggableGrouping.ts 100.00% <100.00%> (ø)

@ghiscoding ghiscoding merged commit 6601998 into master Apr 30, 2023
5 checks passed
@ghiscoding ghiscoding deleted the bugfix/draggable-grouping-hide-grouped-elms branch April 30, 2023 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant