Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MicroModal.close() does not accept an ID selector #112

Closed
roebuk opened this issue Aug 17, 2018 · 2 comments
Closed

MicroModal.close() does not accept an ID selector #112

roebuk opened this issue Aug 17, 2018 · 2 comments

Comments

@roebuk
Copy link
Contributor

roebuk commented Aug 17, 2018

Hi,

Within the documentation MicroModal.close is documented that it takes a string for the ID of the modal is should perform the close on. Yet, within the code, the close function disregards this argument and calls activeModal.closeModal();

Would be is possible to allow MicroModal.close to accept an ID selector and close the modal where the ID matches?
@roebuk roebuk changed the title MicroModal.close() MicroModal.close() does not accept an ID selector Aug 17, 2018
@roebuk roebuk mentioned this issue Aug 17, 2018
Merged
@ghost
Copy link

ghost commented Oct 23, 2018

Reference #133

@ghosh
Copy link
Owner

ghosh commented May 5, 2019

Fixed in #113

@ghosh ghosh closed this as completed May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roebuk @ghosh