Original event is not available for onShow and onClose

[pomartel]

The original event that triggers the opening and closing of the modal is not passed to the onShow or onClose function. This is useful information for my project (ie. need to read a data-attribute on the link that opened the modal) so I added the functionality to my repo in this commit: pomartel@daf4a43

I can bundle this in a clean pull request if it can be useful to others.

[MahbbRah]

YES YES, I'm in badly needs of this feature :(
I tried your updated codes didn't work. can you do readme so we can use that?

[Antimated]

Very much in need of this

[ghosh]

@pomartel Would you be open to submitting a PR?

[pomartel]

Sure @ghosh , I'll have a look at it next week!

[sashahohloma]

I think, i found solution by using other method - show(id, options)
You can use this method with you custom data-attribute, also you should add event listner for this elements.
Check my example:

var modalCustomSelector = 'data-custom-selector';

document.querySelectorAll('[' + modalCustomSelector + ']').forEach( (element) => {
    element.addEventListener('click', (event) => {

        event.preventDefault();
        var modalCustomId = event.target.closest('[' + modalCustomSelector + ']').getAttribute(modalCustomSelector);
        
        MicroModal.show(modalCustomId, {
            disableScroll: true,
            awaitCloseAnimation: true
        });

    });
});

If MicroModal was called this way, you can use MicroModal.close('data-custom-selector')

[pjoulot]

I have found this issue because I was reading the documentation.

I have been through the code and it has been fixed already, but the documentation has not been updated :(

There is a pull request. #258

[ghosh]

Thanks @pjoulot. Seems like I missed this.

[jmosbech]

@ghosh and @pjoulot The npm version and the code in master does not seem to have these changes. Am I missing something?

[ghosh]

@jmosbech This is scheduled for the next release. This should not have been closed before.

[DmytroLitvinov]

Hi @ghosh ,

Thanks a lot of reporting :)
Could we be aware when new release with passing event will released?

[ghosh]

@DmytroLitvinov It should be released in a few weeks.

[ghosh]

Fixed in 0.4.3

[DmytroLitvinov]

Thanks for release :)
Maybe it would also good to track release on GitHub?

[ghosh]

Yes planing on doing that. I'm trying to setup github actions for release. Should be able to track releases on GH soon.