Rework weather options #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost91-
force-pushed
the
weather-options-rework
branch
4 times, most recently
from
d645512
to
8cc8fbb
Compare
ghost91-
force-pushed
the
weather-options-rework
branch
from
b46a5b9
to
6ba4fe6
Compare
Additionally, on failed world migrations, effects are disabled to prevent any potential scene crashes.
ghost91-
force-pushed
the
weather-options-rework
branch
from
9eeb7d0
to
89f707e
Compare
ghost91-
added a commit
that referenced
this pull request
Dec 17, 2021
* There are now sliders for every weather option (except tint).
* The value of option sliders now updates in real time when the slider is moved.
* `speed` is now a relative factor for the base speed of the effect
* The base speed and scale of effects are now adjusted according to the grid size
* `density` now represents the maximum number of particles per grid unit.
* Existing scenes (also in compendiums) are migrated automatically for the new interpretations of
the weather options.
* The `updateWeather` and `switchWeather` hook events have been deprecated. They are still
available and expect options in t he old format. Going forward, the `fxmaster.updateWeather`
and `fxmaster.switchWeather` hook events should be used instead. Th ey expect the new option
format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.