Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release? #88

Closed
jhm-ciberman opened this issue Sep 28, 2021 · 11 comments
Closed

New release? #88

jhm-ciberman opened this issue Sep 28, 2021 · 11 comments
Labels
question Further information is requested

Comments

@jhm-ciberman
Copy link

jhm-ciberman commented Sep 28, 2021

We are in the final stage of developing our new software using HandyControls. Currently we are using HandyControls v3.3.7 but we would benefit a lot of the new features (Mainly the Spanish translations but also the new "DataGrid.Small" and some bugfixes with the TextBox component error validation.)

Any possibility in having a new release?
I've tried using the MyGet builds but they seem a little unstable and crash or fail.

btw: thanks for contributing to such amazing library <3 Love it

@ghost1372
Copy link
Owner

Hi I apologize for the delay
It's been a week since my laptop has been down (Accidentally spilled liquid on the keyboard😁)
The laptop will come back from warranty Tomorrow or the day after tomorrow
I will release a new nuget version this weekend

@jhm-ciberman
Copy link
Author

Oh, no hurries! Probably there is at least one month more until we prepare for release.
Hope your laptop works fine after the service.
And thanks again for being so helpful

@ghost1372
Copy link
Owner

@jhm-ciberman
Copy link
Author

Thank you @ghost1372 for this release. It works amazing!

One little thing, all the combo box drop down menus now look shifted to the right:

image

image

image

Do you recommend me to apply some global style to fix everything? Or should I wait for a next release?

@ghost1372
Copy link
Owner

Hi @jhm-ciberman this is new style for combobox (introduced in last commit)
If you do not like it, you have to modify the combobox style yourself

@jhm-ciberman
Copy link
Author

Oh, thank you. Honestly, it looks terrible. I thought it was a bug. I wonder why did they changed it. I will try to create my own style then. Hope they revert it in the next version. I will open an issue in the original repo to ask.

Thank you!

@ghost1372
Copy link
Owner

Yes, I think the decision was a bit hasty

@ghost1372
Copy link
Owner

@jhm-ciberman FYI
new version 3.3.8.1 released in nuget with combobox design fix

@jhm-ciberman
Copy link
Author

@ghost1372 Thank you a lot! One last thing: any way that HandyOrg/HandyControl#1004 gets fixed? It's the only reason that I'm not yet upgrading to v3.3.8.x. It makes the whole app crash everytime.
The fix it's literally one line of code (per control). I added the required fix at the end of the same issue. It's adding a ?.ToString() at the end of the line https://github.com/HandyOrg/HandyControl/blob/5dcb6dc64915d66a8bb2f16ba68373587a1fa7ff/src/Shared/HandyControl_Shared/Controls/Input/TextBox.cs#L126 in each control wich supports validation (TextBox, PasswordBox, ComboBox, etc).

I tried to fork the repo myself but I have yet to download all the different versions of NET framework to be able to build HandyControl by myself.

@ghost1372
Copy link
Owner

Unfortunately, nabian is very busy this days and Many requests have not been processed. But these problems will definitely be solved soon.

@jhm-ciberman
Copy link
Author

Don't worry. I'm still with 3.3.7. You two make an amazing job for this free and open source library. <3

@ghost1372 ghost1372 added the question Further information is requested label Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants