Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "target" option to package definition #2

Open
ghostdevv opened this issue Jan 17, 2024 · 3 comments
Open

Add "target" option to package definition #2

ghostdevv opened this issue Jan 17, 2024 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ghostdevv
Copy link
Owner

It would be good if a package could define what it supports, currently I have two thoughts for this:

Single target

Typed as 'computer' | 'turtle'. Not a fan of this option as a turtle can run everything a computer can but you might not want that behaviour.

Array of targets

Typed as ('computer | 'turtle')[], this would allow for slightly more control over install targets.

@ghostdevv ghostdevv added enhancement New feature or request help wanted Extra attention is needed labels Jan 17, 2024
@ghostdevv
Copy link
Owner Author

also is it worth differentiating between computer and advanced-computer?

@NimajnebEC
Copy link
Collaborator

NimajnebEC commented Jan 17, 2024

I like the array idea a lot more than single target as I think its more expandable! Although it may be worth calling it something other than "target" as that doesn't quite feel right for an array...

Since turtles can also be advanced why don't we go with ('computer' | 'turtle' | 'basic' | 'advanced')[]

I don't know if we also want to have a pocket computer check? I don't know if we even can do that...

@Mcrevs
Copy link

Mcrevs commented Jan 18, 2024

I think it is useful to distinguish between normal and advanced computers due to the difference in mouse and parallel processing support.

Also it is possible to do a pocket computer check, there is an example on the Computer Craft wiki. It might be a useful distinction due to the different resolutions. Also the inbuilt GPS program blocks you from hosting it on a pocket computer due to it not being stationary.

It also might be a nice idea to be able to have different packages for different targets with the same package name so that you can make assumption about the device without having to check what device it is each time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants