Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests & linter #36

Closed
philipp-classen opened this issue Jan 25, 2022 · 2 comments
Closed

Fix tests & linter #36

philipp-classen opened this issue Jan 25, 2022 · 2 comments

Comments

@philipp-classen
Copy link
Member

Tests are working with Node 14, but fail on Node 16. Maybe there are more reasons, but one is that the code does not always handle rejected promises.

The linter is currently also complaining on master ("warning Unexpected unnamed function func-names").

@philipp-classen
Copy link
Member Author

The integration tests appear to be flaky, but it is hard to understand the pattern. Rerunning tests on the CI does not seem to change the results, which would normally be expected for most types of races or timeouts.

Locally, main fails consistently for me because "chrome.history.onVisited" is not available. On the CI, it is not always reproducible (and repeat does not change anything). Maybe the order in which tests are run makes a difference?

Locally, these changes fix the integration tests: #41

@philipp-classen
Copy link
Member Author

Has been fixed in the meantime: the tests are working now with 14, 16, 18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant