Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy Stats not shown on navigation back #993

Open
chrmod opened this issue Apr 28, 2020 · 0 comments
Open

Privacy Stats not shown on navigation back #993

chrmod opened this issue Apr 28, 2020 · 0 comments
Labels
Feature/Content Blocker Everything to do with Ad and Tracker blocking Type/Bug Something isn't working

Comments

@chrmod
Copy link
Member

chrmod commented Apr 28, 2020

In case when page is loaded from in memory cache - for instance back/forward navigation, there are no requests being block so Content Blocker does not register any Ads/Trackers. Even though technically it is not a bug, it appear as one to users as expectation is to always see how many trackers were blocked.

Potential fix could involve maintaing small in memory cache for Content Blocker stats (per tab), which will be revivied on back/forward navigation.

Challange is to figure out when it should be cleared to prevent memory leaks. But maybe it is not a problems as those stats are very light.

@chrmod chrmod added Feature/Content Blocker Everything to do with Ad and Tracker blocking Type/Bug Something isn't working labels Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature/Content Blocker Everything to do with Ad and Tracker blocking Type/Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant