Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Division by zero in calculateOverallGrossPerformance() #249

Closed
dtslvr opened this issue Aug 3, 2021 · 0 comments · Fixed by #253
Closed

Division by zero in calculateOverallGrossPerformance() #249

dtslvr opened this issue Aug 3, 2021 · 0 comments · Fixed by #253
Assignees
@vzickner @dtslvr
Labels
bug Something isn't working

Comments

@dtslvr
Copy link
Member

dtslvr commented Aug 3, 2021

ghostfolio/apps/api/src/app/core/portfolio-calculator.ts

Line 427 in 84aa542

grossPerformancePercentage.div(completeInitialValue)

completeInitialValue should never be 0.
@dtslvr dtslvr added the bug Something isn't working label Aug 3, 2021
@dtslvr dtslvr mentioned this issue Aug 3, 2021
Closed
@dtslvr dtslvr linked a pull request Aug 4, 2021 that will close this issue
Bugfix/fix division by zero in calculate overall gross performance #253
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vzickner vzickner

@dtslvr dtslvr

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix/fix division by zero in calculate overall gross performance ghostfolio/ghostfolio
2 participants
@vzickner @dtslvr