Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Holdings screen does not work with a Frankfurt exchange transaction #320

Closed
I-Valchev opened this issue Aug 28, 2021 · 4 comments · Fixed by #322
Closed

[bug] Holdings screen does not work with a Frankfurt exchange transaction #320

I-Valchev opened this issue Aug 28, 2021 · 4 comments · Fixed by #322
Assignees
Labels
bug Something isn't working

Comments

@I-Valchev
Copy link
Contributor

Hi @dtslvr, just trying out Ghostfolio and at first glance I must say it looks fantastic. Very well designed and great UX. Thank you for your work and making it open source.

I have an issue (hosted version) with the stock ticker options not always showing up. Sometimes I type part of it and it gets autocompleted, sometimes it does not The issue is that when I don't select one of the options, even if the text is the same (say, APC.F), it won't let me save the transaction.

@dtslvr
Copy link
Member

dtslvr commented Aug 29, 2021

Hello @I-Valchev

Thank you very much for your kind words and reporting this issue. It will help to improve Ghostfol.io further.

I think I could reproduce what you are describing: If you do not select the symbol from the suggestions, the currency is currently not set internally and thus you cannot save the transaction. If the currency would be set, you see the calculated total of the transaction (next to the Save button).

I will fix this in the upcoming days. If you like to give it a try, you could check this component: https://github.com/ghostfolio/ghostfolio/blob/main/apps/client/src/app/pages/portfolio/transactions/create-or-update-transaction-dialog/create-or-update-transaction-dialog.component.ts

@dtslvr dtslvr added the bug Something isn't working label Aug 29, 2021
@dtslvr dtslvr linked a pull request Aug 29, 2021 that will close this issue
@dtslvr
Copy link
Member

dtslvr commented Aug 30, 2021

Hi @I-Valchev

I have merged the fix (#322) and just deployed a new version to the cloud. Can you please verify if the experience of the symbol selection has been improved for you?

I look forward to your feedback.

@dtslvr dtslvr self-assigned this Aug 30, 2021
@I-Valchev
Copy link
Contributor Author

Hey there, @dtslvr ! Thanks for fixing it so soon, I can confirm it is much improved now! Good that you solved it, since it would have taken me a few more days until I can dig in. Maybe for some other PR in the future ;-)

@dtslvr
Copy link
Member

dtslvr commented Aug 31, 2021

That's great to read, @I-Valchev. Thanks a lot for verifying the improved symbol selection and posting your feedback here 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants