-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]*.override.yml overwrites volumes instead of merging #81
Comments
We will probably just adjust the wiki to match this behavior. I thought the tool we're using for yml merge would merge volumes, but I guess I misread the documentation for it. I'll do some tests to confirm and then change the wiki |
@oranblackwell Can I ask what you were trying to do? Did you want to mount your |
@JonathonSunshine basically, I wanted to nest the tv and movie folders under /media as opposed to directly in the root directory. If merging isnt an option I think being able to add additional volume(s) via the .env would be very handy. Possibly create faux-arrays in .env, and then process them accordingly. |
So you have |
@oranblackwell Hi, I messed around with my over ride like this
It was just a straight copy of the In your override, you only had the one line, and it lived up to its name by override ing the default value, if you want to map the same location to two places, you have it both times I guess |
@oranblackwell but to "to nest the tv and movie folders under /media", in the My most recent install, when I started with DockSTARTer, I formatted my SSD in 2 partitions, 32gb and 200GB, install on the 32, mounted the 200gb as Then,
The default behaviour in |
@nemchik @JonathonSunshine So, I didn't actually need to keep For what its worth, before I switched over to DockSTARTer I was running docker from a 16Gb SD Card on a Pi, with a 500Gb USB drive for downloading and extracting of files, and then moving them to a 3tb network drive for playback (ie. via Plex Media Server). My focus had been much less ambitious then DockSTARTer, so I chose to structure things a small bit differently, which gave me control of the container directories from the .env I had mapped out the NZBGet and Deluge configs like below and my intention was to figure out how to automatically inject these variables directly into the programs config files but I discovered DockSTARTer before I had a chance. NZBGet Structure
Deluge Structure
.env
docker-compose.yml
|
@oranblackwell would you be willing to join us on gitter? https://gitter.im/GhostWriters/DockSTARTer I've got questions about your former setup that will be easier to discuss in chat. I'd like to discuss your usage scenarios and see if it's something that makes sense to include in DockSTARTer. |
What I think makes sense for you with DockSTARTer is to set
And then in the containers use Still wouldn't mind to chat on gitter, you can let me know if I'm overlooking something :) |
@oranblackwell After our discussion on Gitter it sounds like you just want the folders to be different on the inside of the containers because of your personal preference, and I outlined briefly that you can do this with overrides. Do you need any additional help with this? (trying to figure out if we need to do anything else to resolve this issue before closing) |
I'm going to close this for now as I believe the answer above resolves the issue, but if anyone is still having trouble with this just reply here and we'll reopen and see if there's another way to address it. |
@nemchik only seeing this now. Thanks for your help. |
Describe the bug
I created 2 override files to alter the directory structure on the mounted volumes. From your wiki page on Overrides I expected the 'volumes' section to be merged with the pre-configured volumes section (expected 4 volumes per service) but the overrides became the only volumes when viewing the re-generated docker.compose.yml
Steps to Reproduce
Create sonar.overwride.yml and radarr.override.yml in their .apps/
<service>
directory as follows:sonar.overwride.yml
radarr.overwride.yml
Regenerate docker-compose.yml with:
$ sudo bash ~/.docker/main.sh -g
Result:
Expected result:
System (please complete the following information):
Linux raspberrypi 4.14.34-v7+ #1110 SMP Mon Apr 16 15:18:51 BST 2018 armv7l GNU/Linux
Raspbian GNU/Linux 9 (stretch)
The text was updated successfully, but these errors were encountered: