Marked regexp patterns as raw strings and bytes to address the invalid escape warning on Python 3.6+ #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d escape warning on Python 3.6+
|
Hello. Invalid because the have just one slash |
mjpieters
reviewed
May 10, 2017
| @@ -1690,7 +1690,7 @@ def num_ctx_switches(self, _ctxsw_re=re.compile(b'ctxt_switches:\t(\d+)')): | |||
| return _common.pctxsw(int(ctxsw[0]), int(ctxsw[1])) | |||
|
|
|||
| @wrap_exceptions | |||
| def num_threads(self, _num_threads_re=re.compile(b'Threads:\t(\d+)')): | |||
| def num_threads(self, _num_threads_re=re.compile(br'hreads:\t(\d+)')): | |||
There was a problem hiding this comment.
This line is now missing the initial T
|
How do you see the warnings? I tried |
|
Also tried |
|
Oh, I see, I was supposed to clean all pyc files first. LGTM except #1057 (comment) |
giampaolo
added a commit
that referenced
this pull request
May 10, 2017
giampaolo
added a commit
that referenced
this pull request
May 10, 2017
|
Awesome guys! Thank you for being so fast and thorough with the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with 3.6.0, invalid escapes in string and byte literals trigger a DepreacationWarning. This diff marks regexp patterns where such escapes occur as "raw". There are probably other occurrences for non-Linux platforms, but since I can't test chances for such platforms I elected to not to make the changes.