Use environment markers for conditional dependencies #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giampaolo
approved these changes
Mar 4, 2018
|
Good stuff. Can't merge it from my phone. I approved the PR so I think you should be able to. |
|
Thanks. I'd be glad to merge, but I don't have write access on the repo. 😄 |
|
I will merge it later then ;)
On Sun, 4 Mar 2018 at 20:02, Jon Dufresne ***@***.***> wrote:
Thanks. I'd be glad to merge, but I don't have merge rights on the repo.
😄
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1230 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAplLKt0jUBlIrtO5a7LLxeXjbSCHHWLks5tbDpWgaJpZM4SbcsS>
.
--
Giampaolo - http://grodola.blogspot.com
|
Using environment markers has support among modern Python packaging tools (setuptools, pip, wheel, etc.). Allows describing environment specific dependencies in setup.py without using runtime logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using environment markers has support among modern Python packaging tools (setuptools, pip, wheel, etc.). Allows describing environment specific dependencies in setup.py without using runtime logic.