Improve sensors_battery for linux platforms #1266
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add fallback for power_now add new paths for power cables
giampaolo
reviewed
Apr 13, 2018
| @@ -1243,7 +1243,9 @@ def multi_cat(*paths): | |||
| energy_full = multi_cat( | |||
| root + "/energy_full", | |||
| root + "/charge_full") | |||
| if energy_now is None or power_now is None: | |||
| if power_now is None: | |||
| power_now = 0 # provide a fallback since some systems don't provide this. | |||
There was a problem hiding this comment.
This doesn't look right. If power_now can't be determined we also cannot determine secsleft so it's probably better to just return None
There was a problem hiding this comment.
but in case power_now is not available this still gives the battery percentage and whether or not the charger is connected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add fallback for power_now
add new paths for power cables