Expanded battery sensor detection #1837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands the battery sensors detection for directories not starting with "BAT" but containing "battery" in the name. (As example on a Pinebook Pro running the default Manjaro distro the folder will be named "cw2015-battery").
It also looks for "/time_to_empty_now" (minutes) which can be used to get "secsleft" if either "energy_now" or "power_now" fails to get a value.
The TestSensorsBattery tests will however fail on a machine that has the "/time_to_empty_now" file present since it won't return "None" in that case. I figured I probably shouldn't mess with the tests and let you do it if this PR gets accepted.