fix: race condition in test_posix.TestProcess.test_cmdline #2153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On macOS the official python installer exposes a python wrapper that executes a python executable hidden inside an application bundle inside the Python framework. There's a race condition in in test_posix.TestProcess.test_cmdline between the ps call & the psutil call depending on the completion of the execve call so let's retry on failure for this test. Signed-off-by: mayeut <mayeut@users.noreply.github.com>
mayeut
force-pushed
the
fix-test-cmdline-rc
branch
from
7d886df
to
c33a300
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description
On macOS the official python installer exposes a python wrapper that executes a python executable hidden inside an application bundle inside the Python framework.
There's a race condition in in test_posix.TestProcess.test_cmdline between the ps call & the psutil call depending on the completion of the execve call so let's retry on failure for this test.