fix(windows): running tests in a virtual environment (alt 2) #2216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On windows, starting with python 3.7, virtual environments use a venvlauncher startup process This does not play well when counting spawned processes or when relying on the pid of the spawned process to do some checks e.g. connection check per pid This commit detects this situation and uses the base python executable to spawn processes when required. Signed-off-by: mayeut <mayeut@users.noreply.github.com>
Signed-off-by: mayeut <mayeut@users.noreply.github.com>
This was referenced Mar 25, 2023
giampaolo
requested changes
Mar 27, 2023
Signed-off-by: mayeut <mayeut@users.noreply.github.com>
mayeut
force-pushed
the
win-venv-tests-env
branch
from
abdeb13
to
a8d8384
Compare
|
Merged. Thank you Matthew. |
giampaolo
added a commit
that referenced
this pull request
Mar 27, 2023
ddelange
added a commit
to ddelange/psutil
that referenced
this pull request
Mar 29, 2023
* 'master' of https://github.com/giampaolo/psutil: [Linux] guess `available` virtual_memory() if kernel says it's 0 (giampaolo#2052) fix C compilation warning on Linux + Python 2 fix linux tests update HISTORY update HISTORY/CREDITS for giampaolo#2216 / @mayeut When raising warning, always use stacklevel=2 Win: fix running tests in a virtual environment (giampaolo#2216)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description
On windows, starting with python 3.7,
virtual environments use a venvlauncher startup process This does not play well when counting spawned processes or when relying on the pid of the spawned process to do some checks e.g. connection check per pid
This commit detects this situation and uses the base python executable to spawn processes when required.
2nd alternative to #2209, exposes PYTHON_EXE_ENV to be set as the base environment when starting a process using PYTHON_EXE.
The 1st commit always uses
env= PYTHON_EXE_ENV.The 2nd commit removes occurrences when calling
psutil.tests.spawn_testproc(either directly or indirectly) which uses this as its default environment.